Add Audible metadata provider via Audimeta#762
Open
cadric wants to merge 3 commits intocalibrain:mainfrom
Open
Add Audible metadata provider via Audimeta#762cadric wants to merge 3 commits intocalibrain:mainfrom
cadric wants to merge 3 commits intocalibrain:mainfrom
Conversation
Collaborator
|
Looks great! thanks for the work. I'll have a full look at this at the weekend. One thing, you mentioned running |
Author
I have added the test_audible.py file. |
Author
|
I pushed two small follow-up fixes:
Also added test coverage for both cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #515
Summary
This adds a new
audiblemetadata provider backed by the Audimeta API.The provider supports:
us,ca,uk,au,fr,de,jp,it,in,es,br)Notes
A few Audimeta-specific integration details were needed:
User-Agent, otherwise Audimeta rejects requests with403cacheparameter in the format Audimeta expectskeywordsfor general search instead ofquery, which gave poor/irrelevant results for title-stylesearches
Validation
Tested locally with:
python -m py_compile shelfmark/metadata_providers/audible.pypython -m pytest tests/metadata/test_audible.py -vpython -m pytest tests/metadata/test_metadata_provider_capabilities.py -vAlso verified manually in a Podman test container:
Discount Danreturns Audible titleB0DXLXRNGGScope
This PR intentionally keeps the change localized to the provider layer and docs: