Feat/typo one word #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make pyproject.toml adhere to PEP 621 - set up uv.lock - test that pytest and pre-commits still function
Need to replace poetry everywhere with uv.
se-jaeger
force-pushed
the
feat/typo-one-word
branch
from
343a90f to
bddff8c
Compare
se-jaeger
approved these changes
May 14, 2025
Member
se-jaeger
left a comment
se-jaeger
left a comment
There was a problem hiding this comment.
LGTM.
Fixed some minor things if you agree feel free to merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that many datasets contain empty strings in columns into which I want to insert Typos. Currently, this causes an error. With this PR, an empty string
""will be replaced by a random character, e.g."a". While that's not a perfect solution, it gets us going.In the future, we could look into dependencies between error types and error mechanisms (e.g., insert Typos into values that are not empty strings, yet preserve the error mechanism as good as possible).
Changes
conftest.pyfor shared fixtures.TypoTypowork with empty strings