NC code to dos #19
Merged
NC code to dos #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igh Level API prep
…updated the high-level api
…ut the object type casting
…and an include list for the error mechanisms.
se-jaeger
reviewed
May 6, 2025
Member
se-jaeger
left a comment
se-jaeger
left a comment
There was a problem hiding this comment.
There are a few TODO statements in the codebase. Can you make sure they still make sense. No need to fix them now but please double check that they are still make sense and are not already solved.
Other than that, I think it's good to go! Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished several TODOs scattered throughout the code base
Added default behavior for some error types
Refactored the permutate error type
Built the basis of the high level API
Updated the getting started notebook with High Level API information
Added tolerance of datetime64 objects for the numerical error types