fix(bookings): generate unique videoCallUrl per recurring booking occurrence#28881
Draft
paulonasc wants to merge 1 commit intocalcom:mainfrom
Draft
fix(bookings): generate unique videoCallUrl per recurring booking occurrence#28881paulonasc wants to merge 1 commit intocalcom:mainfrom
paulonasc wants to merge 1 commit intocalcom:mainfrom
Conversation
…urrence Each Cal Video (Daily.co) recurring booking occurrence now derives its own room URL via `getPublicVideoCallUrl(uid)` instead of sharing the first booking's URL. The fix covers both the `booking.metadata.videoCallUrl` stored in the database and the webhook payloads sent on confirmation. `expectWebhookToHaveBeenCalledWith` now accepts an optional `uid` parameter so tests can assert the correct per-occurrence URL in `BOOKING_CREATED` webhooks, replacing three FIXME comments in `recurring-event.test.ts`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Paulo Nascimento seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getPublicVideoCallUrl(uid)instead of all occurrences sharing the first booking's URLbooking.metadata.videoCallUrlstored in the database and the webhook payloads sent during confirmationuidparameter toexpectWebhookToHaveBeenCalledWith/expectBookingCreatedWebhookToHaveBeenFiredto assert per-occurrence URLsRoot Cause
handleConfirmation.tscomputed a singlemeetingUrlfrom the first booking'sscheduleResultand applied it to all unconfirmed recurring occurrences in the.map()loop. For Daily.co, each booking UID deterministically maps to a unique room URL via/video/<uid>, so sharing the first UID's URL means future meetings point to a stale/expired room.Changes
packages/features/bookings/lib/handleConfirmation.tsgetPublicVideoCallUrl(uid)for Daily.co, with fallback to sharedmeetingUrlfor other providerspackages/testing/src/lib/bookingScenario/expects.tsuidparameter to webhook assertion helpers for filtering by booking uidapps/web/pages/api/book/recurring-event.test.tsTest plan
TZ=UTC yarn test apps/web/pages/api/book/recurring-event.test.ts— all 5 tests passFixes #11955
🤖 Generated with Claude Code