Add RouteBuilderToCallbackFirstRector for CakePHP 6.0#365
Closed
dereuromark wants to merge 1 commit into5.xfrom
Closed
Add RouteBuilderToCallbackFirstRector for CakePHP 6.0#365dereuromark wants to merge 1 commit into5.xfrom
dereuromark wants to merge 1 commit into5.xfrom
Conversation
This rector rule transforms RouteBuilder method calls from the old argument order (params/options second, callback third) to the new order (callback second, params/options third). Affected methods: - scope(path, callback, params) - prefix(name, callback, params) - plugin(name, callback, params) - resources(name, callback, options) Transformations: - 3 args with array second, closure third: swap to callback second - 3 args with empty array second: remove the empty array - resources with 2 args (name + options): insert null as callback Also adds: - CakePHPSetList::CAKEPHP_60 constant - cakephp60.php set file - Full test coverage with fixtures Refs cakephp/cakephp#19095 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Claude on its own didnt understand what target it should use ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new Rector rule to transform RouteBuilder method calls from the old argument order to the new CakePHP 6.0 order where callback comes second and params/options come third.
Affected methods:
scope(path, callback, params = [])prefix(name, callback, params = [])plugin(name, callback, params = [])resources(name, callback = null, options = [])Transformations:
Changes:
RouteBuilderToCallbackFirstRectorclassCakePHPSetList::CAKEPHP_60constantcakephp60.phpset fileRelated:
🤖 Generated with Claude Code