Normalize exception handling in command classes#993
Merged
dereuromark merged 1 commit into5.xfrom Jan 11, 2026
Merged
Conversation
- Remove redundant Exception catch when Throwable already covers it - Use consistent error output formatting with <error> tags - Add verbose trace output to SeedCommand for consistency - Remove unused Exception imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalizes exception handling patterns across command classes for consistency.
Changes
MigrateCommand & RollbackCommand
catch (Exception $e)block sincecatch (Throwable $e)already covers all exceptionsuse Exception;importSeedCommand
catch (Exception $e)tocatch (Throwable $e)for consistency$io->err('<error>...</error>')instead of$io->error()to match other commands$io->verbose($e->getTraceAsString())for debugging consistencyBefore/After
Before (MigrateCommand/RollbackCommand):
After:
Test plan