-
Notifications
You must be signed in to change notification settings - Fork 121
Add unified cake_migrations table support with BC autodetect #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
5192cc3
Add unified cake_migrations table support with BC autodetect
dereuromark 690b078
Address PR feedback for unified migrations table
dereuromark 79ec7d4
Use hasTable() for phinxlog detection
dereuromark e35f3e4
Add CI matrix, tests, docs for unified migrations table
dereuromark a034f31
Remove development notes
dereuromark d756e1f
Merge branch '5.x' into 5.x-unified-migrations-table
dereuromark 329ee61
Hide upgrade command when legacyTables is false
dereuromark f23bef2
Remove LEGACY_TABLES CI matrix, partial test fixes
dereuromark c0ca79a
Cleanup.
dereuromark e69cc8f
Update tests to support unified migrations table mode
dereuromark 42f498f
Remove undefined resetOutput() call from StatusCommandTest
dereuromark 84528b6
Fix test suite for LEGACY_TABLES=false CI build
dereuromark 7b9be94
Update src/Command/MigrationsUpgradeCommand.php
dereuromark ab0af12
Update src/Command/MigrationsUpgradeCommand.php
dereuromark b1b795c
Update docs/en/upgrading-to-builtin-backend.rst
dereuromark dc48661
Update docs/en/upgrading-to-builtin-backend.rst
dereuromark 6fc996b
Update docs/en/upgrading-to-builtin-backend.rst
dereuromark c1fc1b9
Update src/Command/MigrationsUpgradeCommand.php
dereuromark 7643c3b
Update src/Db/Adapter/AbstractAdapter.php
dereuromark 62738aa
Feedback and fixes
markstory 0c3406c
Merge branch '5.x' into 5.x-unified-migrations-table
dereuromark 62ca3fe
Add more tests.
dereuromark f53fcdd
Move files around and add tests
markstory 567aaa5
Add loadbearing gitkeep file.
markstory d38c20e
See if this test is causing CI to fail and emit warnings.
markstory 6e09f62
Narrow type with assert()
markstory 2f27c91
Unskip test, it was the problem after all.
markstory 6b4ffb7
Fix quotes
markstory 8fe27e2
Add another directory.
markstory 65a7323
Fix diff baking tests to delete migration file after running migrate.
dereuromark 7e6b59c
Remove file.
dereuromark 96883d1
Auto create folder. ensures a more stable setup.
dereuromark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesnt this kind of confuse people? Why would people want to upgrade if both sound equal.
The legacy wording makes the upgrade path clear towards 6.x (no phinxlog at all).
This sounds like they have no need to, and as such would stay on the old path forwever.