Conversation
markstory
reviewed
Nov 13, 2025
| ) | ||
| ->create(); | ||
|
|
||
| $this->table('special_pks', ['id' => false, 'primary_key' => ['id']]) |
Member
There was a problem hiding this comment.
Is this the expected behavior now? Generating a migration for a plugin without --require-table will include every table in the database?
Member
Author
There was a problem hiding this comment.
Check the initial report. I think it does make sense as outlined above, since otherwise you couldnt use it for plugins initially at all.
Member
There was a problem hiding this comment.
The original issue doesn't make it clear if the model classes existed or not. I have to assume that the model classes don't exist.
Having the plugin option only change the output directory fits with how other bake tasks work as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #463
Root Cause
The bug was in src/Util/TableFinder.php:72. The code incorrectly treated the --plugin option the same as --require-table, filtering tables to only include those with corresponding Table classes in the plugin. When creating
an initial migration snapshot for a plugin (before Table classes exist), this resulted in an empty migration.
The Fix
Changed line 72 in src/Util/TableFinder.php:
Behavior Changes
Before:
After: