Avoid false which is mangled by PDO

[nicosp]

Fix migrations upgrade with postgres which has native booleans.

Fixes: #1022

[dereuromark]

Is there a test case we might be missing?

[dereuromark]

One suggestion: the current fix handles false but not true. If a breakpoint is set, PostgreSQL would return true which could also be mangled by PDO.

A simpler approach that handles all cases:

'breakpoint' => (int)($row['breakpoint'] ?? 0),

This is also consistent with how breakpoint is used elsewhere in MigrationsTableStorage.php (lines 105, 180).

[nicosp]

Another approach that works is to pass the column type in the insertQuery.

        $schema = $connection->getSchemaCollection()->describe($unifiedTable);

        // Insert into unified table
        foreach ($rows as $row) {
            try {
                $insertQuery = $connection->insertQuery()
                    ->insert(
                        ['version', 'migration_name', 'plugin', 'start_time', 'end_time', 'breakpoint'],
                        [
                            'breakpoint' => $schema->getColumnType('breakpoint'),
                        ]
                    )
...

I am not sure if there is an easier way to do this.

[nicosp]

The pipelines for mariadb seem to be stuck

[LordSimal]

MariaDB needs the same fix from cakephp/cakephp#19273 as that action is broken

[markstory]

Thanks! We can get mariadb fixed separately.

[nicosp]

@markstory Might have merged part of the fix.

The last part:

docker exec mariadb mariadb -h 127.0.0.1 -u root -proot -e 'CREATE DATABASE cakephp_comparisons;'
docker exec mariadb mariadb -h 127.0.0.1 -u root -proot -e 'CREATE DATABASE cakephp_snapshot;'