Merged
Conversation
othercorey
force-pushed
the
add-rfc7231
branch
from
ed66623 to
45e3a59
Compare
Member
I feel like we should get rid of phive. require-dev is just fine. |
ADmad
reviewed
Oct 26, 2025
|
|
||
| public function testToRfc7231String() | ||
| { | ||
| $time = Chronos::parse('2014-04-20 08:00:00'); |
Member
There was a problem hiding this comment.
Could add a non UTC timezone to the string to show the method properly converts the time before formatting.
othercorey
force-pushed
the
add-rfc7231
branch
3 times, most recently
from
5771f1d to
79c6937
Compare
othercorey
force-pushed
the
add-rfc7231
branch
from
79c6937 to
0a4b94c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the deprecated
DATE_RFC7231constant. Added to Chronos only since it doesn't make much sense for ChronosDate even though we include all of FormattingTrait for backwards compatibility.