Conversation
|
The problem with this way of deprecating is, that every Form execution will trigger this deprecation now, no matter if its done by a overwritten class or not. But I can't find any other BC way of doing this without adding reflection to the class (to know if the child class has an overwritten |
LordSimal
force-pushed
the
5.next-deprecate-form_execute
branch
from
137d4e3 to
96af950
Compare
LordSimal
force-pushed
the
5.next-deprecate-form_execute
branch
4 times, most recently
from
71c01ef to
977654b
Compare
| ]; | ||
|
|
||
| $this->assertFalse($form->execute($data)); | ||
| $this->deprecated(function (): void { |
There was a problem hiding this comment.
There also needs to be a test using a class which doesn't override _execute() and overrides process().
LordSimal
force-pushed
the
5.next-deprecate-form_execute
branch
2 times, most recently
from
e660250 to
e40675b
Compare
LordSimal
force-pushed
the
5.next-deprecate-form_execute
branch
from
e40675b to
9d1fe85
Compare
|
I can give this a shot as it was my suggestion. |
|
What needs to be done here? I thought the current state is fine now |
Nothing really. I thought you weren't happy with the results. I think using reflection for these scenarios is quite reasonable. |
3 participants
Refs: #18707