Skip to content

Fix argument type for AuthenticationComponent::setIdentity(). #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markstory merged 1 commit into from
Jul 27, 2025
Merged

Fix argument type for AuthenticationComponent::setIdentity(). #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Controller/Component/AuthenticationComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,10 @@ public function getIdentityData(string $path): mixed
* is cleared and then set to ensure that privilege escalation
* and de-escalation include side effects like session rotation.
*
* @param \ArrayAccess $identity Identity data to persist.
* @param \ArrayAccess|array $identity Identity data to persist.
* @return $this
*/
public function setIdentity(ArrayAccess $identity)
public function setIdentity(ArrayAccess|array $identity)
{
$controller = $this->getController();
$service = $this->getAuthenticationService();
Expand Down
5 changes: 5 additions & 0 deletions tests/TestCase/Controller/Component/AuthenticationComponentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,11 @@ public function testSetIdentity()
$component->setIdentity($this->identityData);
$result = $component->getIdentity();
$this->assertSame($this->identityData, $result->getOriginalData());

$identityData = ['id' => 99];
$component->setIdentity($identityData);
$result = $component->getIdentity();
$this->assertSame($identityData, $result->getOriginalData());
}

/**
Expand Down