Conversation
markstory
reviewed
Apr 26, 2025
|
|
||
| $salt = $this->getConfig('salt', ''); | ||
| if ($identity[$usernameField] === null || $identity[$passwordField] === null) { | ||
| throw new InvalidArgumentException( |
Member
There was a problem hiding this comment.
Wouldn't this create a 500 for the application? Could we use an exception that will render a 40x response instead?
Member
Author
There was a problem hiding this comment.
It should, it is a developer error.
It can only run into this if you misconfigured them afaik.
As otherwise it shouldnt even go into this authenticator that far.
They would at bare minimum be empty strings, never null. Null means you set them to impossible values IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed from username to login, but apparently, one authenticator wasnt adjusted.
this was hard to debug without a clear feedback.