Skip to content

2.x => 3.x merge and fix tests#614

Merged
ADmad merged 28 commits into3.xfrom
3.x-merge
May 1, 2023
Merged

2.x => 3.x merge and fix tests#614
ADmad merged 28 commits into3.xfrom
3.x-merge

Conversation

@LordSimal
Copy link
Copy Markdown
Contributor

No description provided.

dependabot bot and others added 23 commits December 26, 2022 01:41
Bumps [actions/stale](https://github.com/actions/stale) from 6 to 7.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v6...v7)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Needed an explanation of how the Users database table structure is.
Added link to Users table structure
Add missing links to sidebar and further reading
2.x: fix impersonation version info in docs
…s/stale-7

Bump actions/stale from 6 to 7
With "php composer.phar require "cakephp/authentication:^2.0""  result...

"Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - zendframework/zend-diactoros[2.0.0, ..., 2.2.1] require php ^7.1 -> your php version (8.2.3) does not satisfy that requirement.
    - cakephp/authentication 2.0.0 requires zendframework/zend-diactoros ^2.0 -> satisfiable by zendframework/zend-diactoros[2.0.0, ..., 2.2.1].
    - Root composer.json requires cakephp/authentication 2.0 -> satisfiable by cakephp/authentication[2.0.0]."


BUT,  with the change continues the installation without problems. 
(*Cakephp 4.4.11, windows 10, php 8.2.3)
Update composer require command
2.x: add example on how to mimic Auth->deny
Identity objects could contain closures by fetching the original
data we can serialize into the session more consistently. It also
ensures that when we next build an identity that a new decorator is
created.

Fixes #606
Store only the original data in the impersonation session
Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v7...v8)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…s/stale-8

Bump actions/stale from 7 to 8
@LordSimal LordSimal added this to the Future milestone Apr 29, 2023
@LordSimal
Copy link
Copy Markdown
Contributor Author

@ADmad I'd need your help with this named argument finder change. How do we handle this in the OrmResolver?

@ADmad
Copy link
Copy Markdown
Member

ADmad commented Apr 30, 2023

@ADmad I'd need your help with this named argument finder change. How do we handle this in the OrmResolver?

Just changing the following line from $query->find($finder, $options); to $query->find($finder, ...$options); should suffice.

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use RuntimeException;
use function Cake\Core\deprecationWarning;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All deprecations can be simply dropped for 3.x.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, forgot that 🙈

@ADmad
Copy link
Copy Markdown
Member

ADmad commented Apr 30, 2023

I took care of the finder changes.

@ADmad ADmad merged commit b79691e into 3.x May 1, 2023
@ADmad ADmad deleted the 3.x-merge branch May 1, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants