Add clang-format configuration file #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmgunter
commented
Dec 25, 2020
Comment on lines
+29
to
+31
| AlwaysBreakAfterReturnType: All | ||
| ConstructorInitializerAllOnOneLineOrOnePerLine: true | ||
| BinPackParameters: false |
Contributor
Author
There was a problem hiding this comment.
This is probably the biggest divergence from isce3. I think I tend to prefer to use more vertical space than you guys do. Feel free to veto ;)
There was a problem hiding this comment.
that's very close to what i normally do, with one base class constructor per line, followed by one data member per line. the only difference is that i break them out this way even if they would fit. so this is just fine with me
There was a problem hiding this comment.
I prefer this actually, if the parameters are filling up too much vertical space, that's a cue to merge some of them into structs/tuples :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you have different style preferences. Just getting the ball rolling.