Skip to content

Fix for RenderToTextures world space normals with instancing #8156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pandrr merged 2 commits into from
Mar 17, 2026
+11 −2
Merged

Fix for RenderToTextures world space normals with instancing #8156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16f4143
Added mMatrix switch for instancing to rendertargets_slots.vert world…
AMajesticSeaFlapFlap Mar 17, 2026
18afd80
Normalize world space normals in fragment in rendertargets.js
AMajesticSeaFlapFlap Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/corelibs/cgl/rendertargets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export class RenderTargets
else if (type == "Position * ModelView") return " " + outcolor + i + " = vec4(MOD_pos_mv,1.);".endl();

else if (type == "Position Object") return " " + outcolor + i + " = vec4(MOD_pos_object,1.);".endl();
else if (type == "Normal World") return " " + outcolor + i + " = vec4(MOD_normal_world,1.);".endl();
else if (type == "Normal World") return " " + outcolor + i + " = vec4(normalize(MOD_normal_world),1.);".endl();
else if (type == "Normal * ModelView") return " " + outcolor + i + " = vec4(MOD_normal_mv,1.);".endl();
else if (type == "Material Id") return " " + outcolor + i + " = vec4(round(materialId),round(instIdx),0.,1.);".endl();
else if (type == "Object Id") return " " + outcolor + i + " = vec4(objectId,0.,0.,1.);".endl();
Expand Down
11 changes: 10 additions & 1 deletion src/corelibs/cgl/rendertargets_slots.vert
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@


#ifdef MOD_SLOT_POS_NORMAL_WORLD
MOD_normal_world=(mMatrix*vec4(norm,1.0)).xyz;
mat4 MOD_fmMatrix=mMatrix;
#ifdef INSTANCING
#ifdef TEXINSTMAT
MOD_fmMatrix = texInstMat;
#endif
#ifndef TEXINSTMAT
MOD_fmMatrix = iMat;
#endif
#endif
MOD_normal_world=vec3(MOD_fmMatrix * vec4(norm, 0.0));
#endif

Loading