Skip to content

chore: use C++2b#1227

Merged
ken-matsui merged 11 commits intomainfrom
cpp23
Oct 29, 2025
Merged

chore: use C++2b#1227
ken-matsui merged 11 commits intomainfrom
cpp23

Conversation

@ken-matsui
Copy link
Member

No description provided.

@chatgpt-codex-connector
Copy link

💡 Codex Review

cabin/src/Cli.hpp

Lines 29 to 33 in d7e726c

constexpr bool
matchesAny(std::string_view value,
std::initializer_list<std::string_view> choices) noexcept {
return std::ranges::contains(choices, value);
}

P0 Badge Add missing include for std::ranges::contains

matchesAny now calls std::ranges::contains, but this header doesn’t include <algorithm> (or <ranges>). Any translation unit that pulls in Cli.hpp without those headers will fail to compile because std::ranges is undefined. Include the proper standard header here to make the new helper build.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ken-matsui ken-matsui changed the title chore: use C++23 chore: use C++2b Oct 28, 2025
@ken-matsui
Copy link
Member Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ken-matsui
Copy link
Member Author

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ken-matsui ken-matsui enabled auto-merge (squash) October 29, 2025 00:52
@ken-matsui ken-matsui merged commit 80751be into main Oct 29, 2025
30 checks passed
@ken-matsui ken-matsui deleted the cpp23 branch October 29, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant