feat(manifest)!: support test profile#1185
Conversation
|
Warning Rate limit exceeded@ken-matsui has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 17 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughA new "test" build profile is introduced, extending the Changes
Sequence Diagram(s)sequenceDiagram
participant Config as TOML Config
participant Manifest as Manifest Parser
participant Profiles as Profiles Map
Config->>Manifest: Provide TOML with [dev], [release], [test] sections
Manifest->>Manifest: parseDevProfile()
Manifest->>Profiles: Insert "dev" profile
Manifest->>Manifest: parseTestProfile(devProfile)
Manifest->>Profiles: Insert "test" profile (inherits from "dev")
Manifest->>Manifest: parseReleaseProfile()
Manifest->>Profiles: Insert "release" profile
Possibly related PRs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new "test" build profile to the manifest parsing system. The test profile inherits configuration from the "dev" profile by default, providing a specialized build configuration for testing scenarios.
Key changes:
- Adds
Testenum value toBuildProfile::Typeand corresponding formatter support - Implements
parseTestProfile()function that inherits from dev profile instead of base profile - Updates profile parsing logic to include test profile in the profiles map
- Expands test coverage to verify test profile behavior in various scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Builder/BuildProfile.hpp | Adds Test enum value and formatter support for the new test profile type |
| src/Manifest.cc | Implements parseTestProfile function, refactors existing profile parsers for consistency, and adds comprehensive test coverage for test profile scenarios |
3fcd202 to
f21e49f
Compare
7da67ab to
fa62656
Compare
Summary by CodeRabbit
New Features
Bug Fixes
Refactor