Skip to content

feat(manifest)!: support test profile#1185

Merged
ken-matsui merged 1 commit intomainfrom
test-prof
Jul 21, 2025
Merged

feat(manifest)!: support test profile#1185
ken-matsui merged 1 commit intomainfrom
test-prof

Conversation

@ken-matsui
Copy link
Member

@ken-matsui ken-matsui commented Jul 20, 2025

Summary by CodeRabbit

  • New Features

    • Added support for a new "test" build profile, which inherits settings from the "dev" profile but can override specific fields.
    • The "test" profile is now recognized and can be configured in the build configuration.
  • Bug Fixes

    • Updated profile parsing tests to ensure the new "test" profile is correctly handled and inherits values as expected.
  • Refactor

    • Improved consistency in profile parsing logic for easier maintenance.

@coderabbitai
Copy link

coderabbitai bot commented Jul 20, 2025

Warning

Rate limit exceeded

@ken-matsui has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e30eb71 and 08cf47e.

📒 Files selected for processing (3)
  • src/Builder/BuildProfile.hpp (2 hunks)
  • src/Cmd/Test.cc (5 hunks)
  • src/Manifest.cc (6 hunks)

Walkthrough

A new "test" build profile is introduced, extending the BuildProfile::Type enum and updating the formatter to handle this type. The profile parsing logic now supports "test" profiles, which inherit defaults from "dev", and the test suite is updated to validate the new profile's behavior.

Changes

File(s) Change Summary
src/Builder/BuildProfile.hpp Added Test to BuildProfile::Type enum; updated formatter to handle "test" profile.
src/Manifest.cc Added parsing logic for "test" profile, inheriting from "dev"; refactored profile parsing; updated tests.

Sequence Diagram(s)

sequenceDiagram
    participant Config as TOML Config
    participant Manifest as Manifest Parser
    participant Profiles as Profiles Map

    Config->>Manifest: Provide TOML with [dev], [release], [test] sections
    Manifest->>Manifest: parseDevProfile()
    Manifest->>Profiles: Insert "dev" profile
    Manifest->>Manifest: parseTestProfile(devProfile)
    Manifest->>Profiles: Insert "test" profile (inherits from "dev")
    Manifest->>Manifest: parseReleaseProfile()
    Manifest->>Profiles: Insert "release" profile
Loading

Possibly related PRs

  • cabinpkg/cabin#1151: Introduced the initial BuildProfile class with Dev and Release types, refactoring code to use this enum instead of a boolean debug flag. The current PR extends this by adding the Test profile.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ken-matsui ken-matsui requested a review from Copilot July 20, 2025 23:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new "test" build profile to the manifest parsing system. The test profile inherits configuration from the "dev" profile by default, providing a specialized build configuration for testing scenarios.

Key changes:

  • Adds Test enum value to BuildProfile::Type and corresponding formatter support
  • Implements parseTestProfile() function that inherits from dev profile instead of base profile
  • Updates profile parsing logic to include test profile in the profiles map
  • Expands test coverage to verify test profile behavior in various scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/Builder/BuildProfile.hpp Adds Test enum value and formatter support for the new test profile type
src/Manifest.cc Implements parseTestProfile function, refactors existing profile parsers for consistency, and adds comprehensive test coverage for test profile scenarios

@ken-matsui ken-matsui force-pushed the test-prof branch 2 times, most recently from 3fcd202 to f21e49f Compare July 21, 2025 00:08
@ken-matsui ken-matsui changed the title feat(manifest): support test profile feat(manifest)!: support test profile Jul 21, 2025
@ken-matsui ken-matsui force-pushed the test-prof branch 2 times, most recently from 7da67ab to fa62656 Compare July 21, 2025 00:26
@ken-matsui ken-matsui merged commit b2810da into main Jul 21, 2025
23 checks passed
@ken-matsui ken-matsui deleted the test-prof branch July 21, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants