fix: load CWD .env explicitly with correct precedence#28
Merged
Conversation
- Split into loadEnvFile helper + loadConfigEnv orchestrator - Precedence: real env > CWD .env > ~/.config/shopq/.env - Never override existing env vars (fixes test failures) - Use node: protocol for imports (fixes lint)
Tests set SHOPIFY_STORE='' to simulate missing credentials. Using 'in' check instead of falsy check preserves that intent.
The root cause was building with --target=node and #!/usr/bin/env node, which meant Bun's native .env loading never kicked in at runtime. Fix: target bun directly. Bun auto-loads CWD .env — no custom code needed. For global use without a local .env, users export vars in their shell profile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #26. Fixes test failures caused by the initial XDG config implementation.
Changes
loadEnvFilehelper +loadConfigEnvorchestrator.envexplicitly (needed since--target=nodebuild doesn't get Bun's auto-load)Bun.spawnnode:protocol for imports (fixes lint)Precedence (highest → lowest)
.env~/.config/shopq/.env