Skip to content

Conversation

@olivertzeng
Copy link

No description provided.

@c22dev
Copy link
Owner

c22dev commented Mar 6, 2024

Hello, thank you very much for this PR !
First, I need someone to review this translation (I'll actually find someone this time), if nobody can I'll try and use good ol' Google Translate...
Second, please sort your name by alphabetical order and not at the top of the translators. It does not depend on the language's name but on the translator name and it's sorted from A to Z.
Sorry !

@olivertzeng
Copy link
Author

Hello, thank you very much for this PR ! First, I need someone to review this translation (I'll actually find someone this time), if nobody can I'll try and use good ol' Google Translate... Second, please sort your name by alphabetical order and not at the top of the translators. It does not depend on the language's name but on the translator name and it's sorted from A to Z. Sorry !

oh ok ill sort that out but itll look weird though but thanks

@olivertzeng
Copy link
Author

olivertzeng commented Mar 7, 2024

Hello, thank you very much for this PR ! First, I need someone to review this translation (I'll actually find someone this time), if nobody can I'll try and use good ol' Google Translate... Second, please sort your name by alphabetical order and not at the top of the translators. It does not depend on the language's name but on the translator name and it's sorted from A to Z. Sorry !

done

@c22dev

@c22dev
Copy link
Owner

c22dev commented Mar 13, 2024

It's again in alphabetical order in the README.

Accidentally messed up the order
@olivertzeng
Copy link
Author

Alr
Sorry I accidentally messed up the readme order when I added some more translators
It's now fixed @c22dev

@olivertzeng
Copy link
Author

It's again in alphabetical order in the README.

Has the reviewer finished their job?

@c22dev
Copy link
Owner

c22dev commented Apr 1, 2024

I asked on twitter for someone to review this, and nobody replied.
I'm sorry but for now I'll leave this PR open.
And even if I would have merged this it wouldn't be released till a long time (since I am not bringing any changes for now).
Keep in mind I am really happy you made a contribution, and I would be as happy as you would be if I was able to merge this.
Sorry!

@olivertzeng
Copy link
Author

I asked on twitter for someone to review this, and nobody replied. I'm sorry but for now I'll leave this PR open. And even if I would have merged this it wouldn't be released till a long time (since I am not bringing any changes for now). Keep in mind I am really happy you made a contribution, and I would be as happy as you would be if I was able to merge this. Sorry!

That's fine I guess. However I do know some people who use the same language as I do. How about I ask them to do so? I should've have this idea already however I thought that the person will be a little biased about the translations(and also I thought that you've found a person to review my pr already)

Anyways I'm not really angry about you being that cautious about my translations because that's really what a repo maintainer needs to do - being careful about what people commit on your source code. Hopefully that won't make you another xz XD

Again I appreciate your contributions to Geranium and keep up the good work!

@c22dev
Copy link
Owner

c22dev commented Apr 7, 2024

Yeah, no problem really, if they want to review it then why not!

@olivertzeng
Copy link
Author

I asked on twitter for someone to review this, and nobody replied.

I'm sorry but for now I'll leave this PR open.

And even if I would have merged this it wouldn't be released till a long time (since I am not bringing any changes for now).

Keep in mind I am really happy you made a contribution, and I would be as happy as you would be if I was able to merge this.

Sorry!

How about now?

@c22dev
Copy link
Owner

c22dev commented Aug 2, 2025

Hey !
Sorry for the very long wait.. sincerely apologize.
I sadly have no update to bring to my above statement. I'll review it, as mentioned in first comment, with Google Translate during next week along with the other PR.
In the meantime, would you mind resolving conflits if you find some spare time ? I'll do it myself otherwise.
Again, sorry for the wait.
Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants