Ensure MessageTrans_Lookup R4-R7 set to zero if no arguments provided#110
Open
mephillips-durham wants to merge 1 commit intoc-jo:mainfrom
Open
Ensure MessageTrans_Lookup R4-R7 set to zero if no arguments provided#110mephillips-durham wants to merge 1 commit intoc-jo:mainfrom
mephillips-durham wants to merge 1 commit intoc-jo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the message in the Messages file has more parameters than are provided as arguments to the msgtrans_lookup call, then the values of the registers R4 to R7 would be used, despite being unpredictable in value. This change guards against unintended revealing of random memory contents.