User message sending function improvements#104
Merged
Conversation
Make send() and reply() return the task handle returned by _send. In _send(), take the size first from the size parameter if given, but allow it to come from self.size if it has been set, before falling back on the size of the message type. This allows message classes to offer setter functions for complex message entries which set the size of the message automatically. Fix typos in comments.
mephillips-durham
changed the title
Contributor
Author
|
Also fix typo in AboutToBeShown event's structure definition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing size parameter to call of _send() from send().
Make send() and reply() return the task handle returned by _send.
In _send(), take the size first from the size parameter if given, but allow it to come from self.size if it has been set, before falling back on the size of the message type. This allows message classes to offer setter functions for complex message entries which set the size of the message automatically.
Fix typos in comments.