Update Expressions.cs #7
Conversation
We need variable here, not property
|
Hi, thanks for your input. Would you mind explaining how this makes the code better? The properties were read-only while the fields in this PR are read/write and open for modification which is probably not what we want. Thanks. |
|
And why you need this in the first place. Thanks. |
|
Property's getters are not implemented, so this way is shortest to make code working. |
|
The code didn't compiled with error on empty 'get' in properties, so I changed properties to variables and it worked. To make read-only field I suggest add private variable and property which getter returns value of private variable. |
|
The current code (in master) builds without errors. What error are you getting and what Visual Studio version are you using? Why do you need to modify the code? Why not just use the Nuget package? |
2 participants
We need variable here, not property