Open
Conversation
bjschoenfeld
reviewed
Apr 4, 2019
bjschoenfeld
reviewed
Apr 4, 2019
epeters3
reviewed
Aug 6, 2019
Member
|
The cardinalities in the metafeatures.json and the code that computes them need to be cleaned up. I want to fix this after the refactor that is coming soon. Also, I want to separate this from the autocorrelation PR. I will make a separate PR for each. |
epeters3
force-pushed
the
autocorrelation
branch
from
bc41c8a to
ab2a726
Compare
Contributor
|
As requested @bjschoenfeld, I've fixed and cleaned up this PR. It should be ready for your review now. |
JeremyRees
approved these changes
Nov 18, 2019
epeters3
force-pushed
the
autocorrelation
branch
from
c369a5b to
cd5ed74
Compare
Codecov Report
@@ Coverage Diff @@
## develop #160 +/- ##
===========================================
- Coverage 92.36% 92.13% -0.24%
===========================================
Files 13 13
Lines 760 788 +28
===========================================
+ Hits 702 726 +24
- Misses 58 62 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements new metafeatures including autocorrelation, cardinality at 2,3,4, and binary features. It also updates the way that numeric and categorical cardinalities are being calculated.