Open
Conversation
…filer into cross_validation
Comment on lines
+77
to
+78
| del X_train | ||
| del y_train |
Member
There was a problem hiding this comment.
this will happen automatically with python garbage collection when this function returns.
…filer into cross_validation
e13h
reviewed
Jul 8, 2020
e13h
left a comment
e13h
left a comment
There was a problem hiding this comment.
I don't understand much of what's going on with the multiprocessing, but I noticed that there is code for it in get_variables(), evaluate_model(), run_models(), and embed_data(). I just wonder if there's a way to encapsulate it in such a way that the setting up and divvying out of jobs is in one function and running of models, data loading, etc. doesn't have to have any knowledge of multiprocessing.
Other than that, I have made some suggestions about changing how we pass data to the embed() function so that it is a little less clunky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross validation branch. The relevant code is under cross_validation_mpi.py