Conversation
YellowHCH
force-pushed
the
horizontal_fusion
branch
from
e91dca5 to
a5f00f2
Compare
- as title - add hfuse test case - format
- as title, implement a simple heuristic strategy to chose the fusion pattern - fix set-arg-space update op type error
YellowHCH
force-pushed
the
horizontal_fusion
branch
from
deba296 to
ce5920a
Compare
qingyunqu
reviewed
Jul 9, 2024
| isa<mhlo::BroadcastInDimOp, mhlo::BroadcastOp, mhlo::ReshapeOp>( | ||
| target) || | ||
| isa<mhlo::BroadcastInDimOp, mhlo::BroadcastOp, mhlo::ReshapeOp, | ||
| mhlo::TransposeOp>(target) || |
Collaborator
There was a problem hiding this comment.
should not fuse tranpose？
Collaborator
Author
There was a problem hiding this comment.
should not fuse tranpose？
There are unsupported transpose permutation runtime error with horizontal fusion. We need to support these transpose patterns
Collaborator
Author
There was a problem hiding this comment.
I'd like to fix this next time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.