Use our OOM-handling PrimaryMap in the wasmtime_environ::module_artifacts module#12623
Open
fitzgen wants to merge 8 commits intobytecodealliance:mainfrom
Open
Conversation
And also make it so that cloning it doesn't actually require any allocations by wrapping the inner `GcStructLayout` in an `Arc`.
I realized we need to adjust its `V: Clone` bound into `V: TryClone` which means that we can no longer actually just wrap an inner `cranelift_entity::SecondaryMap<K, V>` and need to instead implement our own. This also made me realize that we need `remove` to be fallible because, when the entry being removed is in bounds, it overwrites the entry with the default value, but that default value needs to be `TryClone`d now which is, of course, a fallible operation.
alexcrichton
approved these changes
Feb 18, 2026
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "cranelift", "fuzzing", "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #12622 and its transitive PR deps.