Implement TryClone for RegisteredType and RecGroupEntry in the types registry#12619
Open
fitzgen wants to merge 3 commits intobytecodealliance:mainfrom
Open
Implement TryClone for RegisteredType and RecGroupEntry in the types registry#12619fitzgen wants to merge 3 commits intobytecodealliance:mainfrom
TryClone for RegisteredType and RecGroupEntry in the types registry#12619fitzgen wants to merge 3 commits intobytecodealliance:mainfrom
Conversation
And also make it so that cloning it doesn't actually require any allocations by wrapping the inner `GcStructLayout` in an `Arc`.
alexcrichton
approved these changes
Feb 18, 2026
|
|
||
| impl TryClone for RegisteredType { | ||
| fn try_clone(&self) -> Result<Self, OutOfMemory> { | ||
| Ok(self.clone()) |
Member
There was a problem hiding this comment.
Given the nontrivial complexity here, should this handwritten impl be the try-clone version and Clone is try_clone().panic_on_oom()?
github-actions
bot
added
wasmtime:api
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
TryCloneforGcLayout#12616TryCloneforArc<T>,Option<T>, andResult<T, E>#12615