Avoid cluttering tree with stdout/stderr log files #300
+85
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write output log files to a tmpfile location and remove them on success runs by default. On failure or when using the `-k` option to keep log files, output the path to the logs after the benhmark run.
fitzgen
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write output log files to a tmpfile location and remove them on success runs by default. On failure or when using the
-koption to keep log files, output the path to the logs after the benchmark run.Personally, I would be fine removing the clean command with these changes as well, but I add some impl as it was easy enough. In testing changes, got a bit tired of having hundreds of these files show up in my tree.