fix(tests): update test suite for ResolveSpace middleware + space context#57
Merged
fix(tests): update test suite for ResolveSpace middleware + space context#57
Conversation
…text - Fix phpunit.xml APP_BASE_PATH pointing to /tmp/quality-worktree (was loading wrong migrations/controllers, causing 49 test failures) - Fix duplicate space_id column in competitor_content_items migration - Add authorization check to WebhookAdminController::index() (no permission check existed; endpoint was open to any authenticated user) - Fix cross-space IDOR tests to send X-Space-Id header for anotherSpace so webhook lookup correctly returns 404 when space_id does not match - Regenerate autoloader to fix /tmp/competitor-worktree base path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
49 pre-existing test failures on main.
Root Causes
phpunit.xmlAPP_BASE_PATH pointing to/tmp/quality-worktree(wrong migrations/controllers loaded - Laravel picked up stale worktree files)space_idcolumn in competitor_content_items migrationWebhookAdminController::index()missing authorization checkFixes
phpunit.xmlAPP_BASE_PATH to correct repo pathspace_idcolumn from competitor_content_items migrationauthz->authorize()check toWebhookAdminController::index()X-Space-Idheader for cross-space IDOR testingQuality Gates