Support for different board sizes + coin drop animation#32
Support for different board sizes + coin drop animation#32amanpalariya wants to merge 4 commits intobymayanksingh:masterfrom amanpalariya:master
Conversation
Removed redundant double call to diagonal_win() in winning_move() update logo update logo update logo update logo Resolved undo issue#13 Generalised some expressions Generalised some expressions Works for different board sizes Added animation and changable board patterns Update README.md Create CODE_OF_CONDUCT.md resolved col bug Resolved issue#21 run black on the project Minor bug fixes Added animation and changable board pattern Board pattern Changed a comment
|
@amanpalariya don't be confused, you have done exactly what I asked you to do. |
|
we have some conflicts here.. please remove them.. also I am very happy with your coin drop animation.. can you keep only keep these changes
I am a bit reluctant to merge other changes such as:
What I will suggest is don't do anything with this section, keep it as it is !
|
The message on the top of the screen will always appear in the center for all board sizes
|
Done 👍🏻 |
|
If this PR is merged, people working on issue #7 will have to change the code a little because the board is drawn with coloured rectangle + black circle in their branch and I have done it using transparent tileable pattern |
|
thanks for the amazing job done @amanpalariya |
3 participants
I'm confused