Fix Corrupted Binary from Integer Overflow#2
Open
CoolSpy3 wants to merge 8 commits intobwiedermann:gh-pagesfrom
Open
Fix Corrupted Binary from Integer Overflow#2CoolSpy3 wants to merge 8 commits intobwiedermann:gh-pagesfrom
CoolSpy3 wants to merge 8 commits intobwiedermann:gh-pagesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, specifying an integer or register argument which cannot be encoded in 8 or 4 bits respectively leads to undefined behavior (likely due to string truncation and concatenations which were not designed for use with binary strings longer than 8 bits. (ex, The instruction
setn r1 300gets compiled tosetn r3 44).This PR updates the code which parses integers to truncate the higher-order bytes of numbers which cannot be encoded in 8 bits. Additionally, it adds error messages for any numbers or registers which are out of range.