Enhance AREDN Node integration #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bwarden
reviewed
Jan 1, 2026
bwarden
reviewed
Jan 1, 2026
bwarden
reviewed
Jan 1, 2026
bwarden
reviewed
Jan 1, 2026
bwarden
reviewed
Jan 1, 2026
Owner
|
I increased max line length to 120; that should resolve all those linter complaints. Comments inline with things I'm ok with telling linter to ignore because I think its suggestions detract from clarity. |
Contributor
Author
|
Refactored a few lines let me know what you think now.... |
bwarden
approved these changes
Jan 1, 2026
Owner
|
Bah, ruff is still failing. I think I got its config (.ruff.toml) right this time; you might have to rebase from main for the runner to pick it up for this PR. You can run it locally via scripts/lint. |
…mprove host parsing, and update data handling
For consistency, sure! Co-authored-by: Brett T. Warden <brett.warden@gmail.com>
Co-authored-by: Brett T. Warden <brett.warden@gmail.com>
Co-authored-by: Brett T. Warden <brett.warden@gmail.com>
Co-authored-by: Brett T. Warden <brett.warden@gmail.com>
Co-authored-by: Brett T. Warden <brett.warden@gmail.com>
Refactor IP resolution logic to always attempt resolving and refresh the cached IP for the IP sensor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support SSL and port configuration improve host parsing, and update data handling