Updates docs and adds linter #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tristanlatr
requested changes
Jul 17, 2025
Collaborator
tristanlatr
left a comment
tristanlatr
left a comment
There was a problem hiding this comment.
Thanks for caring about documentation!
configargparse.py
Outdated
| Returns: | ||
| list[IO]: open config files | ||
| list: open config files |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| list: open config files | |
| list[IO]: open config files |
Contributor
Author
There was a problem hiding this comment.
https://github.com/bw2/ConfigArgParse/actions/runs/16356639405/job/46216450614?pr=337
/home/runner/work/ConfigArgParse/ConfigArgParse/configargparse.py:109: Cannot find link target for "IO"
/home/runner/work/ConfigArgParse/ConfigArgParse/configargparse.py:109: Cannot find link target for "IO"
/home/runner/work/ConfigArgParse/ConfigArgParse/configargparse.py:109: Cannot find link target for "IO"
/home/runner/work/ConfigArgParse/ConfigArgParse/configargparse.py:109: Cannot find link target for "IO"
/home/runner/work/ConfigArgParse/ConfigArgParse/configargparse.py:109: Cannot find link target for "IO"
/home/runner/work/ConfigArgParse/ConfigArgParse/configargparse.py:1349: Cannot find link target for "IO"
Contributor
Author
There was a problem hiding this comment.
Ok looks good now
Owner
There was a problem hiding this comment.
@tristanlatr can you please confirm that this PR can be merged?
Co-authored-by: tristanlatr <19967168+tristanlatr@users.noreply.github.com>
kingbuzzman
commented
Jul 17, 2025
kingbuzzman
commented
Jul 17, 2025
Contributor
Author
I care about a lot of things, look at all the PRs i have open 😇 |
bw2
approved these changes
Jul 25, 2025
Owner
|
@kingbuzzman is this PR ready to be merged? |
Contributor
Author
|
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please squash
is_tagsince its not used