Split shortcuts by platform and name them#591
Split shortcuts by platform and name them#591hpohlmeyer wants to merge 1 commit intobustle:masterfrom
Conversation
|
Another approach to this would be to change the |
|
Travis CI fails, because some of the key commands don’t work anymore. For example Before I start modifing the test, I would like to know if you welcome these changes. Thanks! |
|
@hpohlmeyer thanks for diving in here, I've made a note to try and follow up on Friday. 🙇 |
|
I ran into a similar issue as @hpohlmeyer and am supportive of his proposed change. |
|
Closing this as @lukemelia has a modernized version of this PR in #789. |
The main task of this pull request is to name the default shortcuts.
I think the default shortcuts are not bad, but if you want to use mobiledoc kit as a framework you need a way to reset the shortcuts and not just overwrite them. (For example, if you do not want to support underlined text)
You already have the
unregisterKeyCommands()function to delete key commands. Unfortunately, the shortcuts need a name property to delete them. This is what I did for the default commands.Some of them had different functions, depending on the platform. This is why I split the arrays into a mac and a windows array. This way I could give them distinctive names.