Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/manifold/templates/workspace_template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ timestamp:
interval: HOUR
field: timestamp

partitioning:
interval: HOUR

metrics:
renders:
conditions:
Expand Down
16 changes: 15 additions & 1 deletion lib/manifold/terraform/workspace_configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,27 @@ def metrics_table_config(group_name)

def build_table_config(table_id, schema_path = nil)
schema_path ||= "#{table_id.downcase}.json"
{
config = {
"dataset_id" => @name,
"project" => "${var.project_id}",
"table_id" => table_id,
"schema" => "${file(\"${path.module}/tables/#{schema_path}\")}",
"depends_on" => ["google_bigquery_dataset.#{@name}"]
}

maybe_apply_partitioning(config, table_id)
end

def maybe_apply_partitioning(config, table_id)
if @manifold_config&.dig("partitioning", "interval") && table_id != "Dimensions"
interval = @manifold_config["partitioning"]["interval"]
config["time_partitioning"] = {
"type" => interval,
"field" => "timestamp"
}
end

config
end
end

Expand Down
24 changes: 24 additions & 0 deletions spec/manifold/terraform/table_config_builder_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,30 @@
it { is_expected.to include("depends_on" => ["google_bigquery_dataset.#{name}"]) }
end

context "when partitioning config is provided" do
subject(:partitioned_configs) { builder_with_partition.build_table_configs }

let(:partitioning_interval) { "DAY" }
let(:config) { { "partitioning" => { "interval" => partitioning_interval }, "metrics" => { "foo" => {} } } }
let(:builder_with_partition) { described_class.new(name, config) }

it "does not add time partitioning to dimensions table" do
expect(partitioned_configs["dimensions"]).not_to have_key("time_partitioning")
end

it "adds time partitioning to manifold table" do
expect(partitioned_configs["manifold"]).to include(
"time_partitioning" => { "type" => partitioning_interval, "field" => "timestamp" }
)
end

it "includes time partitioning for metric tables" do
expect(partitioned_configs["foometrics"]).to include(
"time_partitioning" => { "type" => partitioning_interval, "field" => "timestamp" }
)
end
end

describe "manifold table configuration" do
subject(:manifold_config) { configs["manifold"] }

Expand Down
Loading