Skip to content

Registry based Poller to return Signal response after the first step.#186

Open
gruggiero wants to merge 2 commits intobusiness4s:mainfrom
gruggiero:RegistryPoller
Open

Registry based Poller to return Signal response after the first step.#186
gruggiero wants to merge 2 commits intobusiness4s:mainfrom
gruggiero:RegistryPoller

Conversation

@gruggiero
Copy link
Contributor

It's meant to be used together with withSingleStepEvaluation.
A test and a minimal example has been added.

It's meant to be used together with withSingleStepEvaluation.
A test and a minimal example has been added.
@Krever
Copy link
Collaborator

Krever commented Dec 6, 2025

Hey, thanks a lot for this!

The code looks good but before going forward I have to think a bit how it fits into the bigger picture.

  1. If we introduce it, does it mean we have two things doing the same thing (poller and knocker upper)? If so, how do we avoid this?
  2. How do we handle discoverability of this feature? Where to put docs for example.

It might take me some time but I will eventually get back with some answers. Thanks again :)

@gruggiero
Copy link
Contributor Author

Yes, I see your points and I agree.

A user willing to use this feature needs to know that the workflow needs to run without a knocker upper as shown in the example, but this is not intuitive nor documented.

I've opened this to show a possible solution, take your time to decide what's best to do with it, no worries :)

In the mean time I'll keep you posted on how it works in our develop environment where is going to be tested and I'll think if it's possible to add this behaviour to the existing knocker.

Thank you

@Krever
Copy link
Collaborator

Krever commented Jan 8, 2026

I started looking into reconciling it with KnockerUpper infrastructure, but in the meantime I noticed one thing: wouldn't it unnecessairly wakeup also instances awaiting signals or timers? If I got the idea correctly this is meant to wakeup only instances that executed one step and might have another one in line.

That being said, it probably invalidates the idea of treating it as knocker upper, as the trigger is different (doesnt have anything to do with timers). I will have to think more about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants