Skip to content

Fix UAF bug in read_ihex_chunks() when first chunk is reallocated #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gatk555 merged 1 commit into from
Dec 27, 2025
Merged

Fix UAF bug in read_ihex_chunks() when first chunk is reallocated #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions simavr/sim/sim_hex.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,12 @@ read_ihex_chunks(
allocation += INCREMENT;
chunk = realloc(chunk, allocation + (sizeof *chunk - 1));

/* Update the pointer in the previous list element */
if ( backlink_p ) backlink_p->next = chunk;
/* Update the pointer in the previous list element or root */
if ( backlink_p ) {
backlink_p->next = chunk;
} else {
*chunks_p = chunk;
}

/* Refresh the pointer to the future chunk */
chunks_p = &chunk->next;
Expand Down