Fix: Ignore lower z bits when erasing flash for page-alignment #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was possible to erase the size of a page not page aligend. Documentation of atmega328 and atmega2560 states that for the erase operation the lower bits of z are ignored. (I guess it wouldn't make sense to not erase page aligned as well :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible to erase the size of a page not page aligend. Documentation of atmega328 and atmega2560 states that for the erase operation the lower bits of z are ignored. (I guess it wouldn't make sense to not erase page aligned as well :)
I am sorry for opening so many PRs, I just only noticed the bug right after the last PR got merged.