Merged
Conversation
🚀 Preview DeploymentVersion ID: |
a5af8e8 to
f6c588d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the OAuth3 authentication flow to improve security and simplify session management. The main changes remove token handling from the client and rely solely on the CVM's session cookie (
sid) for authentication, streamlining the OAuth3 integration. Additionally, sharing and social features now use the current site origin dynamically instead of hardcoding URLs.OAuth3 Authentication Flow Refactor:
sidsession cookie set via the/oauth3reverse proxy. This affects the callback, login, and verify endpoints (src/app/api/oauth3/callback/route.ts,src/app/api/oauth3/login/route.ts,src/app/api/oauth3/verify/route.ts). [1] [2] [3] [4] [5] [6].env.exampleand.env.productionto clarify server-only OAuth3 settings and removed unused client-side OAuth3 base URL variables. [1] [2]Dynamic Site Origin for Sharing:
window.location.origininstead of hardcoded URLs throughout the badge and overloaded pages (src/app/badge/[address]/BadgeContent.tsx,src/app/overloaded/page.tsx). (src/app/badge/[address]/BadgeContent.tsxL204-R207, src/app/badge/[address]/BadgeContent.tsxL221-R221, src/app/overloaded/page.tsxL27-R33)Authentication Redirect Improvements:
/verifyafter OAuth3 login.