Add GetClaimKey query to reclaim_user_map contract#74
Open
justinbarry wants to merge 1 commit intoexample/reclaim-verifierfrom
Open
Add GetClaimKey query to reclaim_user_map contract#74justinbarry wants to merge 1 commit intoexample/reclaim-verifierfrom
justinbarry wants to merge 1 commit intoexample/reclaim-verifierfrom
Conversation
Added a new query message to retrieve the claim key that was set during contract instantiation. This allows external contracts or clients to query which claim key the contract is configured to use.
Contributor
🔍 Crucible Security ReviewSummaryAdds a GetClaimKey query to the reclaim_user_map contract. Exposes the CLAIM_VALUE_KEY stored during instantiation. Security Assessment
Immunefi Pattern Check
False Report Risk
Code Quality
RecommendationApprove - Low-risk query addition with proper implementation |
Contributor
crucible-burnt
left a comment
There was a problem hiding this comment.
🔍 Crucible Security Review
Summary
Simple query addition to expose the claim_key value.
Security Assessment
- Risk Level: Low
- Read-only query exposing already-stored configuration value
- No state mutations, no auth bypass potential
Immunefi Pattern Check
- ✅ No matches against known vulnerability classes
False Report Risk
- None - straightforward getter pattern
Code Quality Notes
- Clean implementation following existing patterns in the contract
Status
✅ No security concerns identified.
Contributor
crucible-burnt
left a comment
There was a problem hiding this comment.
🔍 Crucible Security Review
Summary
Adds a GetClaimKey query to expose the configured claim key from storage. Minimal change, low risk.
Security Assessment
- Risk Level: Low
- Simple read-only query returning the
CLAIM_VALUE_KEYfrom storage - No state mutation, no access control needed (public query)
- No input validation concerns (no parameters)
Immunefi Pattern Check
- No matches against known vulnerability classes
False Report Risk
- None identified
Code Quality Notes
- Clean implementation following existing query patterns
- Consider adding a test for this query
Status
Clean, no issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetClaimKeyquery message to the reclaim_user_map contractChanges
GetClaimKey {}variant toQueryMsgenum with#[returns(String)]attributeCLAIM_VALUE_KEYstorageTest plan