Skip to content

Add GetClaimKey query to reclaim_user_map contract#74

Open
justinbarry wants to merge 1 commit intoexample/reclaim-verifierfrom
feature/add-claim-key-query
Open

Add GetClaimKey query to reclaim_user_map contract#74
justinbarry wants to merge 1 commit intoexample/reclaim-verifierfrom
feature/add-claim-key-query

Conversation

@justinbarry
Copy link
Contributor

Summary

  • Added a new GetClaimKey query message to the reclaim_user_map contract
  • Implemented the query handler to return the claim key stored during contract instantiation

Changes

  • Added GetClaimKey {} variant to QueryMsg enum with #[returns(String)] attribute
  • Implemented query handler that loads and returns the claim key from CLAIM_VALUE_KEY storage

Test plan

  • Build the contract to ensure no compilation errors
  • Deploy and test the new query returns the expected claim key
  • Verify existing queries still work as expected

Added a new query message to retrieve the claim key that was set during contract instantiation. This allows external contracts or clients to query which claim key the contract is configured to use.
@crucible-burnt
Copy link
Contributor

🔍 Crucible Security Review

Summary

Adds a GetClaimKey query to the reclaim_user_map contract. Exposes the CLAIM_VALUE_KEY stored during instantiation.

Security Assessment

  • Risk Level: Low (read-only query addition)
  • No state mutations
  • No new attack vectors
  • Returns existing public contract state

Immunefi Pattern Check

  • ✅ No vulnerabilities detected
  • ✅ Simple read-only operation

False Report Risk

  • None identified - straightforward query

Code Quality

  • Clean implementation
  • Proper return type annotation
  • Minimal change surface

Recommendation

Approve - Low-risk query addition with proper implementation

Copy link
Contributor

@crucible-burnt crucible-burnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Crucible Security Review

Summary

Simple query addition to expose the claim_key value.

Security Assessment

  • Risk Level: Low
  • Read-only query exposing already-stored configuration value
  • No state mutations, no auth bypass potential

Immunefi Pattern Check

  • ✅ No matches against known vulnerability classes

False Report Risk

  • None - straightforward getter pattern

Code Quality Notes

  • Clean implementation following existing patterns in the contract

Status

✅ No security concerns identified.

Copy link
Contributor

@crucible-burnt crucible-burnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Crucible Security Review

Summary

Adds a GetClaimKey query to expose the configured claim key from storage. Minimal change, low risk.

Security Assessment

  • Risk Level: Low
  • Simple read-only query returning the CLAIM_VALUE_KEY from storage
  • No state mutation, no access control needed (public query)
  • No input validation concerns (no parameters)

Immunefi Pattern Check

  • No matches against known vulnerability classes

False Report Risk

  • None identified

Code Quality Notes

  • Clean implementation following existing query patterns
  • Consider adding a test for this query

Status

Clean, no issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants