PlotterMonitor: only autoRange if no max value was given #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the PlotterMonitor does auto-ranging of the plotter. However, if we explicitly specified a maximum value, that doesn't make much sense, because it renders the maximum value pretty much ineffective. Therefore, enable autoRange only if max_value is not set. This requires us to set an explicit rangeMin and rangeMax. rangeMin is forced to zero (which may or may not be appropriate, but we currently don't have a configuration option for it). rangeMax is set to 1 because the data is normalized so that it is 1 if it reaches max_value. Note that if autoRange is true, rangeMin and rangeMax are ignored. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the PlotterMonitor does auto-ranging of the plotter. However,
if we explicitly specified a maximum value, that doesn't make much
sense, because it renders the maximum value pretty much ineffective.
Therefore, enable autoRange only if max_value is not set.
This requires us to set an explicit rangeMin and rangeMax. rangeMin is
forced to zero (which may or may not be appropriate, but we currently
don't have a configuration option for it). rangeMax is set to 1 because
the data is normalized so that it is 1 if it reaches max_value.
Note that if autoRange is true, rangeMin and rangeMax are ignored.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) arnout@mind.be