Fix problems with timers longer than 60min. Add hours display for timers longer than 60 minutes#1
Open
MaciejPopenda wants to merge 1 commit intoburkeholland:masterfrom
Open
Conversation
- Modified getTimeRemaining to calculate hours - Updated display format to show 'Xh Ym Zs' for timers >= 60 minutes - Keeps original MM:SS format for timers under 60 minutes - Fixes issue where long timers displayed confusing minute counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Improves timer display for durations longer than 60 minutes by showing hours.
Problem
Currently, a 90-minute timer displays as "30:00" which is a wrong value.
Solution
Testing
Screenshots
For 30min timer:
For 345min
