Skip to content

controllers/api.php coding standard violations resolved #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahads wants to merge 6 commits into
base: main
Choose a base branch
from
Open

controllers/api.php coding standard violations resolved #2575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eae10fe
controllers/api.php coding standard violations resolved
mahads Jan 19, 2021
339d95e
controllers/apimaker.php coding standard violations resolved
mahads Jan 19, 2021
e084a6e
controllers/app.php coding standard violations resolved
mahads Jan 20, 2021
cb2a180
controllers/complaint.php coding standard violations resolved
mahads Jan 20, 2021
004649f
controllers/cron.php coding standard violations resolved
mahads Jan 24, 2021
4b56979
controllers/customreports.php coding standard violations resolved
mahads Jan 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 31 additions & 26 deletions application/controllers/api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,8 +920,8 @@ public function saverecords() {
///////////////////////// HASSAN ANWAR ////////////////////////////
///////////////////////////////////////////////////////////////////////

$multiChoices = $this->db->query("Select * from form_multiselectFieldLabels where formId='$form_id'");
foreach($multiChoices->result() as $row)
$multi_choices = $this->db->query("Select * from form_multiselectFieldLabels where formId='$form_id'");
foreach($multi_choices->result() as $row)
{
$fd=(array) $dataresultnew1;

Expand Down Expand Up @@ -958,9 +958,8 @@ public function saverecords() {

}

try{
$ret_ins = $this->db->insert( 'zform_'.$form_id, $final_array );

try {
$ret_ins = $this->db->insert('zform_'.$form_id, $final_array);
if(!$ret_ins){
$err_msg .= $this->db->_error_message();
$this->form_results_model->update_mobile_activity($activity_inserted_id,array('error'=>$err_msg));
Expand All @@ -971,7 +970,7 @@ public function saverecords() {
exit();
}
$form_result_id_new = $this->db->insert_id();
}catch (Exception $e) {
} catch (Exception $e) {
$this->form_results_model->update_mobile_activity($activity_inserted_id,array('error'=>$e->message()));
echo json_encode($jsone_array);
exit;
Expand All @@ -980,9 +979,9 @@ public function saverecords() {


if (!empty($sub_table_record)) {
foreach ($sub_table_record as $sb_key => $sb_value) {
foreach ($sub_table_record as $sb_key => $sub_value) {
$subtable_name = 'zform_' . $form_id . '_' . $sb_key;
foreach ($sb_value as $sub_array) {
foreach ($sub_value as $sub_array) {
$sub_comon_fields = array();
foreach ($sub_array as $fild_key => $filds) {
$sub_fild_ary = array(
Expand Down Expand Up @@ -1029,7 +1028,7 @@ public function saverecords() {
$post_url = '';
if (!empty($form_info ['post_url'])) {
$post_url = $form_info ['post_url'];
} else if (!empty($form_info ['fv_post_url'])) {
} elseif (!empty($form_info ['fv_post_url'])) {
$post_url = $form_info ['fv_post_url'];
}

Expand Down Expand Up @@ -1144,7 +1143,7 @@ public function saverecordscron() {
$replacement = '$1-$2-$3 $4:$5:$6';
$activity_datetime = preg_replace($pattern, $replacement, $dateTime_device);
$activity_datetime = date('Y-m-d H:i:s', strtotime($activity_datetime));
} else if (strpos($dateTime_device, '/') < 12) {
} elseif (strpos($dateTime_device, '/') < 12) {
$pattern = '#(\d+)/(\d+)/(\d+) (\d+):(\d+):(\d+)#';
$replacement = '$1-$2-$3 $4:$5:$6';
$activity_datetime = preg_replace($pattern, $replacement, $dateTime_device);
Expand Down Expand Up @@ -1189,7 +1188,7 @@ public function saverecordscron() {
}
$record[$key] = 'SHOW RECORDS';
}
} else if ($cap_first [0] == 'caption') {
} elseif ($cap_first [0] == 'caption') {
$tempary_cap = array(
$key => $v
);
Expand Down Expand Up @@ -1284,8 +1283,10 @@ public function saverecordscron() {
}


$this->form_results_model->update_mobile_activity($activity_inserted_id, array('form_data_decoded' => json_encode($dataresultnew1)));
$ret_ins = $this->db->insert('zform_' . $form_id, $dataresultnew1);
$this->form_results_model->update_mobile_activity(
$activity_inserted_id, array('form_data_decoded' => json_encode($dataresultnew1))
);
$ret_ins = $this->db->insert('zform_'.$form_id, $dataresultnew1);
$form_result_id_new = $this->db->insert_id();
if (!$ret_ins) {
$err_msg .= 'Record Not Submitted. ' . $this->db->_error_message() . '. "Please Refresh your application"';
Expand Down Expand Up @@ -1324,7 +1325,7 @@ public function saverecordscron() {
'form_id' => $form_id,
'image' => $image_path['image']
);
if(strpos($image_path ['title'], $form_info['security_key']) !== FALSE){
if (strpos($image_path ['title'],$form_info['security_key']) !== FALSE) {
$add_images ['title'] = urldecode(base64_decode(str_replace($form_info ['security_key'], '', $image_path ['title'])));
} else {
$add_images ['title'] = urldecode($image_path ['title']);
Expand All @@ -1343,7 +1344,7 @@ public function saverecordscron() {
$post_url = '';
if (!empty($form_info ['post_url'])) {
$post_url = $form_info ['post_url'];
} else if (!empty($form_info ['fv_post_url'])) {
} elseif (!empty($form_info ['fv_post_url'])) {
$post_url = $form_info ['fv_post_url'];
}

Expand Down Expand Up @@ -1425,7 +1426,7 @@ public function saverecordsharzindagi() {
where id ='$form_id'");
$security_key_result = $query->row_array();
$saved_security_key=$security_key_result['security_key'];
if($security_key != $saved_security_key){
if ($security_key != $saved_security_key) {
$jsone_array = array(
'error' => 'Security key does not match'
);
Expand All @@ -1434,7 +1435,11 @@ public function saverecordsharzindagi() {
}

//Stop activity saving if already saved
$activity_aready_exist = $this->db->get_where('zform_'.$form_id, array('form_id' => $form_id, 'imei_no' => $imei_no,'activity_datetime' => $activity_datetime))->row_array();
$activity_aready_exist = $this->db->get_where('zform_'.$form_id,
array(
'form_id' => $form_id,
'imei_no' => $imei_no,
'activity_datetime' => $activity_datetime))->row_array();
if ($activity_aready_exist) {
$jsone_array = array(
'success' => 'This activity already submitted.'
Expand Down Expand Up @@ -1722,7 +1727,7 @@ public function saverecordsweb() {
}
$record[$key] = 'SHOW RECORDS';
}
} else if ($cap_first [0] == 'caption') {
} elseif ($cap_first [0] == 'caption') {
$tempary_cap = array(
$key => $v
);
Expand Down Expand Up @@ -1760,7 +1765,7 @@ public function saverecordsweb() {
{
$warning_message = 'Your location mismatched. ';
}
else{
else {
$warning_message = 'You are on right location' ;
}
}
Expand Down Expand Up @@ -1892,16 +1897,16 @@ public function saverecordsweb() {
///////////////////////// HASSAN ANWAR ////////////////////////////
///////////////////////////////////////////////////////////////////////

$multiChoices = $this->db->query("Select * from form_multiselectFieldLabels where formId='$form_id'");
foreach($multiChoices->result() as $row)
$multi_choices = $this->db->query("Select * from form_multiselectFieldLabels where formId='$form_id'");
foreach ($multi_choices->result() as $row)
{
$fd=(array) $dataresultnew1;

$label=$row->fieldLabel;
$choicesSent= $dataresultnew1[$label];
$choicesSent=explode(',',$choicesSent);

foreach($choicesSent as $choice)
foreach ($choicesSent as $choice)
{
$choice=str_replace(' ', '_', $choice);
$dataresultnew1[$label.'_'.$choice]='1';
Expand Down Expand Up @@ -2101,9 +2106,9 @@ public function getTownName($location = null) {
curl_setopt($ch, CURLOPT_URL, $url);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
//$body = curl_exec($ch);
if( ! $body = curl_exec($ch)) {
if (!$body = curl_exec($ch)) {
return false;
}else{
} else {
$townname = json_decode($body, 1);
if ($townname != 'null_string') {
return $townname;
Expand All @@ -2128,9 +2133,9 @@ public function getDistrictName($location = null) {
curl_setopt($ch, CURLOPT_URL, $url);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
$body = curl_exec($ch);
if( ! $body = curl_exec($ch)) {
if (!$body = curl_exec($ch)) {
return false;
}else{
} else {
$districtname = json_decode($body, 1);
if ($districtname [0]) {
return $districtname [1];
Expand Down
Loading