Conversation
updated manifest to V3
The background script now uses chrome.scripting.executeScript and separate files for the injected code. It also includes an on-installed listener to guide new users to the options page.
code to inject when adding a URL.
code to inject when adding a note.
Changed version number back to the original 1.1.0, as there are no feature changes, only plumbing. Owner can change to an appropriate version number if pull request is accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello burgyl,
Thank you for a great extension which I love using with Shaarli. Unfortunately it has fallen short of the recent updates and requirements to chrome extensions. I hope to fix that with this pull request. It migrates the extension from the deprecated Manifest V2 to Manifest V3 to comply with the latest Chrome Web Store policies.
Key changes include:
manifest.jsonto version 3.chrome.tabs.executeScriptwith the more securechrome.scripting.executeScript.addUrl.js,addNote.js).I've used this version as a local install for the last week, which works, but I don't have a chrome web store developer account, so I can't actually check if the extension meets the requirements.
Best,
voss