Merged
Conversation
…te module (#21457) ## Which issue does this PR close? Closes #21433 ## Rationale for this change As noted by @alamb in #21182 (comment), `file_scan_config.rs` has grown large after the sort pushdown optimization. This PR extracts the sort pushdown helpers into their own module to improve readability and maintainability. ## What changes are included in this PR? Move sort pushdown logic from `file_scan_config.rs` (3591 → 3066 lines) into a new `sort_pushdown.rs` module (576 lines): - `rebuild_with_source`, `try_sort_file_groups_by_statistics` - `sort_files_within_groups_by_statistics`, `any_file_has_nulls_in_sort_columns` - `validate_orderings`, `is_ordering_valid_for_file_groups` - `get_projected_output_ordering`, `ordered_column_indices_from_projection` - `SortedFileGroups` struct `try_pushdown_sort` stays in the `DataSource` impl — it calls into the new module. ## Are these changes tested? Pure refactor, all existing tests pass (120 passed). ## Are there any user-facing changes? No.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )