Merged
Conversation
…al 'substrait' feature (#21268) ## Which issue does this PR close? - Closes #21269 ## Rationale for this change `datafusion-substrait` is a heavyweight dependency that most developers and users don't need. Making it optional saves compile time for the common case. ## What changes are included in this PR? - `datafusion-substrait` is now an optional dependency in `datafusion-sqllogictest/Cargo.toml` - New `substrait` feature flag gates the dependency - `#[cfg(feature = "substrait")]` gates the module, imports, and `run_test_file_substrait_round_trip` function - No-op fallback function returns an error when the feature is disabled - CI workflow updated to pass `--features substrait` for the round-trip test ## Are these changes tested? - Compiles without `substrait` feature (default) - Compiles with `--features substrait` - CI substrait round-trip test updated to enable the feature ## Are there any user-facing changes? No — this only affects the sqllogictest binary, not the datafusion library itself. The substrait round-trip test requires `--features substrait` to run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )