fix(utils): disables the SP800-132 compliance checks on FIPS-mode. #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use PBKDF2 with SHA-256 (single iteration) on FIPS-mode. However, the SP800-132 compliance checks have constraints, with an iteration count of at least 1000. If we do not disable this check, the following error will occur: ``` unable to derive session encryption key (kdf:derive: error:1C80007B: Provider routines:kdf_pbkdf2_set_ctx_params:invalid iteration count:implementations/kdfs/pbkdf2.c:208:) ``` For backwards compatibility, I would tend to disable the checks rather than increase the iteration. Ref: - https: //github.com/openssl/openssl/blob/openssl-3.0.9/providers/implementations/kdfs/pbkdf2.c#L208 - https: //github.com/openssl/openssl/commit/f0efeea29eca6e528a976f62ae2422eee34ea0eb
ms2008
force-pushed
the
fix/disable-pkcs5-checks-for-fips
branch
from
ec8b051 to
6dde03c
Compare
bungle
requested changes
Jul 28, 2025
lib/resty/session/utils.lua
Outdated
Comment on lines
595
to
598
| -- Disables the SP800-132 compliance checks on FIPS-mode. This checks has constraints for the iteration count is at least 1000. | ||
| if is_fips_mode() then | ||
| PBKDF2_SHA256_OPTS.pkcs5 = 1 | ||
| end |
Owner
There was a problem hiding this comment.
Suggested change
| -- Disables the SP800-132 compliance checks on FIPS-mode. This checks has constraints for the iteration count is at least 1000. | |
| if is_fips_mode() then | |
| PBKDF2_SHA256_OPTS.pkcs5 = 1 | |
| end | |
| -- Disables the SP800-132 compliance checks on FIPS-mode. This checks has constraints for the iteration count is at least 1000. | |
| PBKDF2_SHA256_OPTS.pkcs5 = 1 |
PBKDF2 is only used in FIPS mode, and we can turn this always on.
Or actually I would put this to top level here:
https://github.com/bungle/lua-resty-session/blob/master/lib/resty/session/utils.lua#L633
Owner
|
@ms2008 can you also add it here in docs: |
bungle
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use PBKDF2 with SHA-256 (single iteration) on FIPS-mode. However, the SP800-132 compliance checks have constraints, with an iteration count of at least 1000. If we do not disable this check, the following error will occur:
For backwards compatibility, I would tend to disable the checks rather than increase the iteration.
Ref: