Skip to content

Conversation

@monroepe
Copy link
Collaborator

@monroepe monroepe commented Dec 16, 2025

Description

  • Added many eslint rule that are currently enforced in internal frontend repos
  • Fixed violations of those rules
  • Disabled the lint rules where it would have required additional code changes (these can be reviewed for updates at a later date)
  • The bulk of the changes were made using npm run lint:fix with a few manual additions or updates to match style preferences

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

Visit the preview URL for this PR (updated for commit a5bbfd1):

https://novo-elements--pr1748-f-new-eslint-rules-lfgi2a27.web.app

(expires Mon, 12 Jan 2026 13:56:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

@monroepe monroepe changed the title F/new eslint rules style(cleanup): Add new eslint rules and fix violations Dec 16, 2025
@monroepe monroepe merged commit fa60bdf into next Jan 5, 2026
5 checks passed
@monroepe monroepe deleted the f/new-eslint-rules branch January 5, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants