Skip to content

Conversation

@ndickerson
Copy link
Member

Description

Several items got added to the IDataTablePreferences that are not required to be in Novo Elements, and causes us to make a lot of typing additions that are Novo specific. Migrating these types to Novo by extending the IDataTablePreferences in Novo for the Novo-specific types. This avoids adding a bunch more Novo-specific types in this ticket.

If the cleanup is not possible because of backwards-compat issues, I can instead kill this MR, start the extension of the types in Novo now, and not do this backwards-incompatible cleanup.

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit ed9e1a3):

https://novo-elements--pr1677-f-type-cleanup-fuqnc0ig.web.app

(expires Fri, 23 May 2025 18:34:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant